@stoutes
Will TAL tomorrow. Make sure you rebase off of dev-ovpn, I just merged in our .ovpn recursive descent parser in #314 as well as #309.

I'd presume the builder should/would mesh with that in some way. We'd want to reconcile the approach we made in #309 for OpenVpnConfig as well with the version you created.

Please also update your PR description as well to mention the issues you tackled directly. It looks like you're doing both #292 and #299. In the future, I'd prefer you keep a PR to one issue, unless they're related in some fashion. (#288 is just the tracking issue for OpenVPN support so I wouldn't call them related).

Lastly, HUGE nitpick, but your commit messages should be feat(#<ISSUE_NUMBER>) or feat(nmrs). We don't use lib or the verbose feature.

I'd presume the builder should/would mesh with that in some way. We'd want to reconcile the approach we made in #309 for OpenVpnConfig as well with the version you created.

So for the meshing are you thinking of some sort of conversion so the parser output can flow into the builder?

I'd presume the builder should/would mesh with that in some way. We'd want to reconcile the approach we made in #309 for OpenVpnConfig as well with the version you created.

So for the meshing are you thinking of some sort of conversion so the parser output can flow into the builder?

@stoutes
No, sorry I should have been clearer. What I meant is just that #309 was already merged into dev-openvpn. The struct that was developed in there looks like this

pub struct OpenVpnConfig {
    pub name: String,
    pub remote: String,
    pub port: u16,
    pub tcp: bool,
    pub auth_type: Option<OpenVpnAuthType>,
    pub auth: Option<String>,
    pub cipher: Option<String>,
    pub dns: Option<Vec<String>>,
    pub mtu: Option<u32>,
    pub uuid: Option<Uuid>,
    pub ca_cert: Option<String>,
    pub client_cert: Option<String>,
    pub client_key: Option<String>,
    pub key_password: Option<String>,
    pub username: Option<String>,
    pub password: Option<String>,
}

Slightly different from yours.

All you need to do is rebase onto dev-ovpn to get the latest changes. And then extend the existing OpenVpnConfig from #309 with your new compression and proxy fields instead of creating a second struct. Keep all the auth/cipher/tcp/mtu fields since the builder needs to handle more than just TLS. Then write a TryFrom<OvpnFile> for OpenVpnConfig so the parser output flows straight into the builder, and update build_openvpn_connection to dispatch on auth_type instead of hardcoding connection-type: tls.